-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid redundant CMap-value lookup in extendCMap
(PR 5101 follow-up)
#19057
Avoid redundant CMap-value lookup in extendCMap
(PR 5101 follow-up)
#19057
Conversation
When iterating through `useCMap` the value is already available, without having to manually invoke the `lookup`-method. While this will likely not affect performance in any noticeable way, it's nonetheless unnecessary to lookup an already available value twice.
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c4b7ab566668faf/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/604b97e2973a057/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/604b97e2973a057/output.txt Total script time: 2.59 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c4b7ab566668faf/output.txt Total script time: 6.93 mins
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6f7b3dd7e43ab94/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/779f56424fcd06b/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing tests. Thanks!
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6f7b3dd7e43ab94/output.txt Total script time: 20.48 mins
Image differences available at: http://54.241.84.105:8877/6f7b3dd7e43ab94/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/779f56424fcd06b/output.txt Total script time: 25.68 mins
|
When iterating through
useCMap
the value is already available, without having to manually invoke thelookup
-method.While this will likely not affect performance in any noticeable way, it's nonetheless unnecessary to lookup an already available value twice.